audit by DiabeticTurtle · Pull Request #2 · DiabeticTurtle/DiamodPlugins

DiabeticTurtle · 2021-07-13T21:00:35Z

No description provided.

code-review-doctor

Looks good. Worth considering though. View full project report here.

code-review-doctor · 2022-10-10T09:25:04Z

+
+info_json = Path(__file__).parent.resolve() / "info.json"
+with open(info_json, encoding="utf-8") as f:
+    __plugin_info__ = json.loads(f.read())


Suggested change

__plugin_info__ = json.loads(f.read())

__plugin_info__ = json.load(f)

This can be simplified by using json.load(...). More details.

code-review-doctor · 2022-10-10T09:25:05Z

+        if args["nick"]:
+            matched_here = []
+            for user in matched:
+                if any([user.nick and piece.lower() in user.nick.lower() for piece in args["nick"]]):


Suggested change

if any([user.nick and piece.lower() in user.nick.lower() for piece in args["nick"]]):

if any(user.nick and piece.lower() in user.nick.lower() for piece in args["nick"]):

any can take a generator, so constructing a list first may be unnecessary. Read more.

code-review-doctor · 2022-10-10T09:25:05Z

+        if args["name"]:
+            matched_here = []
+            for user in matched:
+                if any([piece.lower() in user.display_name.lower() for piece in args["name"]]):


Suggested change

if any([piece.lower() in user.display_name.lower() for piece in args["name"]]):

if any(piece.lower() in user.display_name.lower() for piece in args["name"]):

As above, Constructing a list first may be unnecessary.

code-review-doctor · 2022-10-10T09:25:05Z

+        if args["not-nick"]:
+            matched_here = []
+            for user in matched:
+                if not any([user.nick and piece.lower() in user.nick.lower() for piece in args["not-nick"]]):


Suggested change

if not any([user.nick and piece.lower() in user.nick.lower() for piece in args["not-nick"]]):

if not any(user.nick and piece.lower() in user.nick.lower() for piece in args["not-nick"]):

As above, Constructing a list first may be unnecessary.

code-review-doctor · 2022-10-10T09:25:05Z

+        if args["not-user"]:
+            matched_here = []
+            for user in matched:
+                if not any([piece.lower() in user.name.lower() for piece in args["not-user"]]):


Suggested change

if not any([piece.lower() in user.name.lower() for piece in args["not-user"]]):

if not any(piece.lower() in user.name.lower() for piece in args["not-user"]):

Again, Constructing a list first may be unnecessary.

code-review-doctor · 2022-10-10T09:25:06Z

+        if args["not-discrim"]:
+            matched_here = []
+            for user in matched:
+                if not any([disc == int(user.discriminator) for disc in args["not-discrim"]]):


Suggested change

if not any([disc == int(user.discriminator) for disc in args["not-discrim"]]):

if not any(disc == int(user.discriminator) for disc in args["not-discrim"]):

Same as above: Constructing a list first may be unnecessary.

code-review-doctor · 2022-10-10T09:25:06Z

+
+info_json = Path(__file__).parent.resolve() / "info.json"
+with open(info_json, encoding="utf-8") as f:
+    __plugin_info__ = json.loads(f.read())


Suggested change

__plugin_info__ = json.loads(f.read())

__plugin_info__ = json.load(f)

This can be simplified by using json.load(...). Explained here.

code-review-doctor · 2022-10-10T09:25:07Z

+
+info_json = Path(__file__).parent.resolve() / "info.json"
+with open(info_json, encoding="utf-8") as f:
+    __plugin_info__ = json.loads(f.read())


Suggested change

__plugin_info__ = json.loads(f.read())

__plugin_info__ = json.load(f)

This can be simplified by using json.load(...). More details.

code-review-doctor · 2022-10-10T09:25:07Z

+            try:
+                user = await self.bot.get_or_fetch_user(user_id)
+            except (discord.NotFound, Exception):
+                raise commands.BadArgument('"{}" not found. Invalid user ID.'.format(user_id))


f-string is easier to read, write, and less computationally expensive than legacy string formatting. More details.

code-review-doctor · 2022-10-10T09:25:07Z

+        except Exception as exc:
+            err = f"{type(exc).__name__}: {str(exc)}"
+            raise commands.BadArgument(
+                "Error renaming {name}#{discrim}.\n```Haskell\n{error}\n```".format(


As above, Consider using f-string instead.

code-review-doctor

Worth considering. View full project report here.

code-review-doctor · 2022-12-06T22:40:04Z

+from discord.ext import commands
+
+
+class SafeFormat(object):


Suggested change

class SafeFormat(object):

class SafeFormat:

SafeFormat inherits from object by default, so explicitly inheriting from object is redundant. Removing it keeps the code simpler. Read more.

code-review-doctor · 2022-12-06T22:40:04Z

+        self.__dict = kw
+
+    def __getitem__(self, name):
+        return self.__dict.get(name, SafeString('{%s}' % name))


Suggested change

return self.__dict.get(name, SafeString('{%s}' % name))

return self.__dict.get(name, SafeString(f'{{{name}}}'))

f-string is easier to read, write, and less computationally expensive than legacy string formatting. More.

code-review-doctor · 2022-12-06T22:40:04Z

+        try:
+            super().__getattr__(name)
+        except AttributeError:
+            return SafeString('%s.%s}' % (self[:-1], name))


Suggested change

return SafeString('%s.%s}' % (self[:-1], name))

return SafeString(f'{self[:-1]}.{name}}}')

As above, Consider using f-string instead.

Co-Authored-By: p5nbTgip0r <32445075+p5nbtgip0r@users.noreply.github.com>

remove rainbow circle and add support for animated pfps

feat(tags): slash command

code-review-doctor Bot suggested changes Oct 10, 2022

View reviewed changes

code-review-doctor Bot suggested changes Dec 6, 2022

View reviewed changes

DiabeticTurtle added 28 commits December 8, 2022 18:42

Update ModContact.py

c5d8d88

Update tags.py

adcd37b

Update tags.py

bbbb0bb

Update tags.py

05105d4

Update tags.py

463ad61

Update tags.py

7eefe11

Update tags.py

6ef4ba4

Update tags.py

a63dc31

Update tags.py

98b47ae

Update tags.py

df455e8

Update tags.py

71482a7

Update tags.py

7491518

Update tags.py

8aeec19

add pages to lists

37a338b

Update tags.py

9967ed2

update

0f00fe0

Update tags.py

ee9db38

Update tags.py

9c9cb45

Update tags.py

eb3131e

update

860e1c9

Update requirements.txt

2efe7df

Update requirements.txt

8ec4459

update

9946cfa

Update tags.py

45b6096

Update tags.py

f6ed0fc

Update tags.py

941741a

Update tags.py

b3a399d

add edit category

0858a1d

DiabeticTurtle and others added 30 commits November 1, 2023 20:00

Update beetify.py

c30918a

Update beetify.py

984dd84

Update beetify.py

5491704

Update beetify.py

c28552d

Update beetify.py

54342d3

Update beetify.py

6090549

Co-Authored-By: p5nbTgip0r <32445075+p5nbtgip0r@users.noreply.github.com>

Update beetify.py

61ae940

Update beetify.py

34e067c

Update beetify.py

a63d93d

Update beetify.py

322a7ea

Update beetify.py

305f066

Update beetify.py

99639fa

Update beetify.py

83f50a5

Update beetify.py

8aadeb4

Update README.md

0280a23

Update README.md

3c1d3f7

Update beetify.py

62c87d2

remove rainbow circle and add support for animated pfps

Merge branch 'main' of https://github.com/DiabeticTurtle/DiamodPlugins

3526dff

Update beetify.py

1c41078

revert

34ebbbd

Update requirements.txt

a194cc3

test

ec0ea6b

Create pumpchart.md

9c62cbb

Update pumpchart.md

4698a0c

Update requirements.txt

ca3deac

Update requirements.txt

2692e05

Update tags.py

381f7d8

covidwaste

8f7621e

feat(tags): slash command

7545958

Merge pull request #5 from p5nbTgip0r/tags-slashcmd

bbb7136

feat(tags): slash command

	__plugin_info__ = json.loads(f.read())
	__plugin_info__ = json.load(f)

	if any([user.nick and piece.lower() in user.nick.lower() for piece in args["nick"]]):
	if any(user.nick and piece.lower() in user.nick.lower() for piece in args["nick"]):

	if any([piece.lower() in user.display_name.lower() for piece in args["name"]]):
	if any(piece.lower() in user.display_name.lower() for piece in args["name"]):

	if not any([user.nick and piece.lower() in user.nick.lower() for piece in args["not-nick"]]):
	if not any(user.nick and piece.lower() in user.nick.lower() for piece in args["not-nick"]):

	if not any([piece.lower() in user.name.lower() for piece in args["not-user"]]):
	if not any(piece.lower() in user.name.lower() for piece in args["not-user"]):

	if not any([disc == int(user.discriminator) for disc in args["not-discrim"]]):
	if not any(disc == int(user.discriminator) for disc in args["not-discrim"]):

	return self.__dict.get(name, SafeString('{%s}' % name))
	return self.__dict.get(name, SafeString(f'{{{name}}}'))

	return SafeString('%s.%s}' % (self[:-1], name))
	return SafeString(f'{self[:-1]}.{name}}}')

Conversation

DiabeticTurtle commented Jul 13, 2021

Uh oh!

code-review-doctor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

code-review-doctor Bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor Bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor Bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor Bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor Bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor Bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor Bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor Bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor Bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor Bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

code-review-doctor Bot Dec 6, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor Bot Dec 6, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor Bot Dec 6, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants